Initial implementation for strict flag #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchw
commented
Feb 22, 2021
| if !c.opt.AllowLocally { | ||
| return errors.New("LOCALLY cannot be used when --strict is specified") | ||
| } | ||
|
|
There was a problem hiding this comment.
This is in converter, because it (to me) helps interpreter stay clean. Interpreter is for language, Converter is where CLI options + interpreted language options are combined, and so also is where the relevant error lives.
Co-authored-by: Vlad A. Ionescu <446771+vladaionescu@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small prereq that can standalone as I add in support for
RUN --interactiveStill needs an integration test though