Create config path if missing

[dchw]

Looser permissions, plus create directory separately.

[dchw]

Not even sure if this is needed since it seems to work in 0.5.2, was just throwing up something to see if it helped you

…

On Wed, Feb 24, 2021 at 5:51 PM Alex Couture-Beil ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In config/config.go <#812 (comment)>: > @@ -350,5 +351,10 @@ func ReadConfigFile(configPath string, contextSet bool) ([]byte, error) { // WriteConfigFile writes the config file to disk with preset permission 0644 func WriteConfigFile(configPath string, data []byte) error { - return ioutil.WriteFile(configPath, data, 0644) + err := os.MkdirAll(path.Dir(configPath), 0755) + if err != nil { + return err + } + + return ioutil.WriteFile(configPath, data, 0755) seems a bit odd to mark this config file as executable, I think setting it to 0644 is more correct. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#812 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAICAMECKRXJ3FZP4QPYEZTTAWNIXANCNFSM4YFQ2FXQ> .