With docker locally #840
Merged
With docker locally #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcb
force-pushed
the
with-docker-locally
branch
6 times, most recently
from
69affcd
to
a78b1ba
Compare
alexcb
force-pushed
the
with-docker-locally
branch
from
a78b1ba
to
177f93e
Compare
alexcb
force-pushed
the
with-docker-locally
branch
9 times, most recently
from
558c07d
to
1ba0ce0
Compare
I was able to get docker compose working in this test: https://github.com/earthly/earthly/pull/840/files#diff-4141aec9ede776e8e9f60ce8be4517a0431dbc996c9fdd9977ff34a4c8489026R13 what's sort of interesting is there's no explicit COPY directive to pull in the docker-compose.yml file since it's already in the current directory on the local machine.
Yeah I was wondering a bit about that too, there's some code that was copy/pasted from there, but a fair amount of it changed. |
alexcb
force-pushed
the
with-docker-locally
branch
from
1ba0ce0
to
687bb1d
Compare
vladaionescu
approved these changes
Apr 7, 2021
alexcb
force-pushed
the
with-docker-locally
branch
from
43df971
to
801b4d5
Compare
- this implements support for building a container, then loading it into the local host, then running it under a LOCALLY target.
alexcb
force-pushed
the
with-docker-locally
branch
from
801b4d5
to
5fee9e5
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the code needs some loving, but here's an initial not-ready-for-review draft of running with docker locally.