-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of IMPORT #868
Conversation
…ved. Not yet used.
@@ -166,6 +174,11 @@ func (c *Collection) ExitFrame() { | |||
c.effectiveCache = nil | |||
} | |||
|
|||
// IsStackAtBase returns whether the stack has size 1. | |||
func (c *Collection) IsStackAtBase() bool { | |||
return len(c.stack) == 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we check for a condition like
if len(c.stack) == 0 { panic("shouldnt happen") }
then again if it's empty that might cause some nil exceptions elsewhere. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - we actually have such a check in popStackFrame
Re #581
Syntax is: