bugfix for handling env vars that end in \\ #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcb
force-pushed
the
test-envs
branch
2 times, most recently
from
7a540e8
to
bf134dd
Compare
- env variables ending in \\ erronorously wrapped to the second line;
e.g.
ENV foo \\
RUN echo bar
would end up setting foo="RUN echo bar"
Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
vladaionescu
approved these changes
Mar 20, 2021
alexcb
added a commit
that referenced
this pull request
Mar 31, 2021
- env variables ending in \\ erronorously wrapped to the second line;
e.g.
ENV foo \\
RUN echo bar
would end up setting foo="RUN echo bar"
Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env variables ending in \ erroneously wrapped to the second line;
e.g.
would end up setting foo="RUN echo bar"
Signed-off-by: Alex Couture-Beil alex@earthly.dev