Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various random improvements #892

Merged
merged 6 commits into from
Mar 25, 2021
Merged

Various random improvements #892

merged 6 commits into from
Mar 25, 2021

Conversation

vladaionescu
Copy link
Member

  • Print stack traces when --verbose is used
  • fmt.Errorf -> errors.Errorf s.t. it includes stack trace
  • Random staticcheck fixes
  • Limit the amount of time a connection is attempted for when waiting for buildkitd to start up

dchw
dchw approved these changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@dchw dchw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

conslogging/conslogging.go Outdated Show resolved Hide resolved
@vladaionescu vladaionescu enabled auto-merge (squash) March 25, 2021 22:12
@vladaionescu vladaionescu merged commit 7cc369f into main Mar 25, 2021
@vladaionescu vladaionescu deleted the vlad/random-improvements branch March 25, 2021 22:27
alexcb pushed a commit that referenced this pull request Mar 31, 2021
@vladaionescu @alexcb
Various random improvements (#892)
4a9f169 
* Fix some linting.

* fmt.Errorf -> errors.Errorf

* Use raw regexp to simplify use of \

* Even better wait logic.

Co-authored-by: Vlad A. Ionescu <vladaionescu@users.noreply.github.com>
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchw dchw dchw approved these changes

@alexcb alexcb Awaiting requested review from alexcb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladaionescu @dchw