expand secret-file path #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically the shell will expand paths such as ~/foo; however when given as an argument to --secret-file secret=~/foo, the shell did not expand this path. This addresses this issue. Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
| return homeDir, nil, err | ||
| } | ||
| // See if SUDO_USER exists. Use that user's home dir. | ||
| sudoUserName, ok := os.LookupEnv("SUDO_USER") |
There was a problem hiding this comment.
I think @dchw had a nice function for fetching the current user or sudo user in his PR. Might be worth merging them somehow.
There was a problem hiding this comment.
This code came from the cliutil.DetectHomeDir() function; If we can fold more code into using this function that sounds like a good plan.
| ) | ||
|
|
||
| // GetUserHomeDirs returns a map of all users and their homedirs | ||
| func GetUserHomeDirs() (map[string]string, error) { |
There was a problem hiding this comment.
I feel that this is too much logic for what is normally needed... but hey... I guess it's now already written.
There was a problem hiding this comment.
this code was moved here from our autocompletion.getUsers(), no new code was written in this PR for this function.
vladaionescu
approved these changes
May 17, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically the shell will expand paths such as
~/foo; however when givenas an argument to
--secret-file secret=~/foo, the shell did not expandthis path. This addresses this issue.
Signed-off-by: Alex Couture-Beil alex@earthly.dev