Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export function instead of its returned value #63

Closed
wants to merge 1 commit into from

Conversation

m-kusnierz
Copy link

This package doesn't work correctly together with Opentelemetry packages.

Changes:

Exported function in lib/nodeerrors.js instead of exporting value returned by the function to avoid caching the value (so the errors definitions)

It uses update moduleconfig that accepts a directory that should be checked for config, because it was also being cached by opentelemetry package (so it was always looking for the config in the same directory).

Used parent-module because of module.parent deprecation nodejs/node#32217

Depends on ebdrup/moduleconfig#6

Breaking change: export function instead of value returned from it to avoid caching the value
@@ -14,6 +14,7 @@
},
"dependencies": {
"moduleconfig": "^2.0.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be updated after releasing changes from ebdrup/moduleconfig#6

@m-kusnierz
Copy link
Author

I'm closing this PR as we decided to implement these changes in forked repository for now.

@m-kusnierz m-kusnierz closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant