Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent navigation #376

Merged
merged 88 commits into from Mar 18, 2020
Merged

Conversation

manuelmeister
Copy link
Member

Die Desktop- und Mobile-Navigation wurden optimiert. Auf Mobile ist das zentrale Element die Suchbar auf der Camp Seite ( neu die Picasso/EventList Seite)
Mit der CardView einen generischen Komponent für den Hauptinhalt erstellt.
Versuch den Loading-Filter zu erstellen.

Fixes #360, fixes #263, fixes #361, fixes #366

@manuelmeister manuelmeister requested review from carlobeltrame and usu and removed request for carlobeltrame and usu February 29, 2020 23:46
Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich erhalte diverse eslint warning. Könntest du noch den linter laufen lassen? Oder deinen Editor konfigurieren, dass er gleich autolint macht beim Speichern?

frontend/src/components/base/BackButton.vue Outdated Show resolved Hide resolved
frontend/src/components/base/ButtonAdd.vue Show resolved Hide resolved
frontend/src/components/form/ApiWrapper.vue Show resolved Hide resolved
frontend/src/components/form/ApiWrapper.vue Show resolved Hide resolved
frontend/src/views/BottomBar.vue Outdated Show resolved Hide resolved
frontend/src/views/Profile.vue Show resolved Hide resolved
frontend/src/views/TopBar.vue Outdated Show resolved Hide resolved
frontend/src/views/camp/Periods.vue Outdated Show resolved Hide resolved
frontend/src/views/camp/TopBar.vue Outdated Show resolved Hide resolved
frontend/src/router.js Outdated Show resolved Hide resolved
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht sehr gut aus jetzt, mit dem Router funktioniert alles wunderbar. Good job!
Ich habe noch zwei Konsolen-Fehler gefunden und dir die Fixes dafür hier vorgeschlagen. Wenn du das gemacht hast ist das auch von mir aus okay 👍

frontend/src/views/NavDesktop.vue Outdated Show resolved Hide resolved
frontend/src/views/NavDesktop.vue Outdated Show resolved Hide resolved
frontend/src/views/camp/NavDesktop.vue Outdated Show resolved Hide resolved
frontend/src/views/camp/NavDesktop.vue Outdated Show resolved Hide resolved
frontend/src/views/event/DayOverview.vue Outdated Show resolved Hide resolved
@manuelmeister manuelmeister merged commit 5838bbd into ecamp:devel Mar 18, 2020
@manuelmeister manuelmeister deleted the consistent-navigation branch March 18, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants