Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

master: preserve only in upload end #2702

Closed
wants to merge 1 commit into from

Conversation

makandre
Copy link
Contributor

Signed-off-by: Andrew Mak makandre@ca.ibm.com

What type of PR is this ?

  • Bug fix
  • Enhancement

What does this PR do ?

Follow-up to PR #2695, preserve timestamp only in upload/end and not in bind/end

Which issue(s) does this PR fix ?

Link to the Codewind repository issue(s) this PR fixes or references:

#2699

Does this PR require a documentation change ?

Any special notes for your reviewer ?

Signed-off-by: Andrew Mak <makandre@ca.ibm.com>
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #2702 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2702      +/-   ##
==========================================
- Coverage   60.55%   60.51%   -0.04%     
==========================================
  Files         102      102              
  Lines       10306    10306              
  Branches     1734     1735       +1     
==========================================
- Hits         6241     6237       -4     
- Misses       4065     4069       +4     
Impacted Files Coverage Δ
src/pfe/portal/modules/utils/sharedFunctions.js 84.26% <100.00%> (ø)
src/pfe/portal/routes/projects/bind.route.js 82.35% <100.00%> (ø)
src/pfe/portal/routes/projects/internal.route.js 48.43% <0.00%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8304cf4...2e30fbf. Read the comment docs.

@makandre
Copy link
Contributor Author

Closing since @hhellyer found it was an fs-extra bug and the proper fix is to upgrade that package. See #2699 (comment) and PR #2705

@makandre makandre closed this Apr 17, 2020
@makandre makandre deleted the hotfix branch May 20, 2020 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant