refactor (jkube-kit) : Move logic for adding OpenShift Build specific properties to DefaultGeneratorManager #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #3037 (2024-05-14T13:52:55Z) ⚙️ JKube E2E Tests (9080295619)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3037 +/- ##
=============================================
+ Coverage 59.36% 71.01% +11.65%
- Complexity 4586 5076 +490
=============================================
Files 500 488 -12
Lines 21211 19440 -1771
Branches 2830 2500 -330
=============================================
+ Hits 12591 13805 +1214
+ Misses 7370 4421 -2949
+ Partials 1250 1214 -36 ☔ View full report in Codecov by Sentry. |
|
I'll rebase this once #3042 is in. |
… properties to DefaultGeneratorManager In Resource mojo and tasks, we've duplicated code that adds the following properties to JavaProject in case of OpenShift mode: - `jkube.image.user` : Sets image user property to currently logged in OpenShift namespace so that image user portion points to namespace - `jkube.internal.effective.platform.mode` : Used by some enrichers to determine whether current platform is OpenShift. This looks like a remnant of Fabric8 Maven Plugin refactor. We should get rid of this in follow up PR. This PR only moves code from Mojos/Tasks -> DefaultGeneratorManager.generateAndMerge() Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
force-pushed
the
pr/refactor-openshiftmode-namespace-properties
branch
from
58ea643
to
d7eed61
Compare
rohanKanojia
commented
May 14, 2024
| @@ -21,6 +21,7 @@ | |||
| import java.util.List; | |||
| import java.util.Optional; | |||
|
|
|||
| import com.networknt.schema.utils.StringUtils; | |||
There was a problem hiding this comment.
You've imported wrong StringUtils
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
pr/refactor-openshiftmode-namespace-properties
branch
from
d7eed61
to
62f78c8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Resource mojo and tasks, we've duplicated code that adds the following properties to JavaProject in case of OpenShift mode:
jkube.image.user: Sets image user property to currently logged in OpenShift namespace so that image user portion points to namespacejkube.internal.effective.platform.mode: Used by some enrichers to determine whether current platform is OpenShift. This looks like a remnant of Fabric8 Maven Plugin refactor. We should get rid of this in follow up PR.This PR only moves code from Mojos/Tasks -> DefaultGeneratorManager.generateAndMerge()
Type of change
test, version modification, documentation, etc.)
Checklist