replace deprecated org.apache.commons.io.input.CountingInputStream with org.apache.commons.io.input.BoundedInputStream #3044
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th org.apache.commons.io.input.BoundedInputStream Signed-off-by: Rohit Satya <work.rohitsatya@gmail.com>
Eclipse JKube CI ReportStarted new GH workflow run for #3044 (2024-05-13T11:34:05Z) ⚙️ JKube E2E Tests (9061993447)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3044 +/- ##
=============================================
+ Coverage 59.36% 70.85% +11.49%
- Complexity 4586 5087 +501
=============================================
Files 500 490 -10
Lines 21211 19592 -1619
Branches 2830 2529 -301
=============================================
+ Hits 12591 13882 +1291
+ Misses 7370 4481 -2889
+ Partials 1250 1229 -21 ☔ View full report in Codecov by Sentry. |
|
@rohit-satya : Did you verify that Helm Chart Push functionality is working as expected? |
@rohanKanojia I have not as of yet, also in the SonarCloud Code Analysis there is issue with |
|
@rohit-satya : You're right. I think we can use |
|
@rohanKanojia Makes sense, will make the change and check how to verify Helm Chart Push functionality |
Signed-off-by: Rohit Satya <work.rohitsatya@gmail.com>
|
|
@rohanKanojia I have made the required code changes, I will need some time to verify Helm Chart Push functionality. |
|
@rohit-satya : Did you get any time to test this PR? I can see you're creating other PRs but there isn't any update on this one. Please try to complete a single task before moving on to the next one. |
|
@rohanKanojia I will be working on testing this PR next as I didn't have the setup to test. |
|
Hi @rohanKanojia I will need a little more guidance in understanding what needs to be done for testing out this PR changes. Could you please redirect me to a relevant resource for the same? And is there a specific yaml file that needs to be pushed. I did check the video mentioned in the issue description but did not get complete context |
|
@rohit-satya could you elaborate what you did try and where you are stuck ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3029
Type of change
test, version modification, documentation, etc.)
Checklist