Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variables in Maven Installations #1454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jun 26, 2023

Currently maven installations only support a fixed path but for certain setups it would be desirable to use a variable.

This adds support for specify a variable in the path for an external installation.

Fix #1372

grafik
grafik

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

Test Results

106 files  ±0  106 suites  ±0   10m 17s ⏱️ -43s
660 tests ±0  649 ✔️  - 1  10 💤 ±0  1 +1 
660 runs  ±0  648 ✔️  - 1  11 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 82a43fa. ± Comparison against base commit 8c4961d.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member Author

laeubi commented Jun 26, 2023

@HannesWell @mickaelistria any idea about the failing test? I can't see any relation to my changes here?! I can't even find my code changes to be executed as no external maven is used in the test...

@HannesWell
Copy link
Contributor

Looks good after a quick look.

@HannesWell @mickaelistria any idea about the failing test? I can't see any relation to my changes here?! I can't even find my code changes to be executed as no external maven is used in the test...

Not immediately, sorry. I can try to have a look in the next days.

@laeubi
Copy link
Member Author

laeubi commented Jun 27, 2023

I now trying to find the offending change iteratively here:

#1459

running the test from the IDE even fails on master :-\

Currently maven installations only support a fixed path but for certain
setups it would be desirable to use a variable.

This adds support for specify a variable in the path for an external
installation.

Fix eclipse-m2e#1372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide project-relative maven installation
2 participants