Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified UI setting for toolchains #1691

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Unified UI setting for toolchains #1691

wants to merge 9 commits into from
+583 −117

Conversation

G-Ork
Copy link
Contributor

@G-Ork G-Ork commented Feb 18, 2024

I redesigned the Maven user settings and add the sections Global & User. For booth there are now settings & toolchains options.

  • Added default path hints for global settings and global toolchains. They are only rendered for external maven installations. Don't forget to apply changes to see them.
  • Unify settings override through goals field. All four settings could be put into the goal in short form (-gt. -gs, -t, -s).
  • Throw exception during launch if path to a settings file is invalid.
  • Provide unit-tests for maven launcher for all four settings
  • Fix a bug in settings validation. Parser problems are not copied to result if parser do not crash. All well formed xml-files are treated as valid.
Maven-Usersettings-Draft

@G-Ork
first wave
4b28e4c
@G-Ork
fix
c2c1284
@G-Ork
Add missing settings arguments to maven launcher & UI redesign
5ce3d72 
- cleanup user settings dialog
- Fix settings validation
- add missing XSDs to eclipse XML catalog contribution
- provide unit test for maven launcher
@G-Ork
Merge branch 'Maven_global_settings_and_toolchains_UI_cleanup' of git…
f6fb6a2 
…@github.com:G-Ork/m2e-core.git into Maven_global_settings_and_toolchains_UI_cleanup
@G-Ork
Merge remote-tracking branch 'origin/master' into
5249bdb 
Maven_global_settings_and_toolchains_UI_cleanup
@G-Ork
Rename IConsumer & add missing global toolchains on context
6f443d2 
configuration.
@G-Ork
Use constants for Maven CLI arguments.
2ef6b03
@G-Ork
Bump Bundle-Version
8e37c42
@G-Ork G-Ork mentioned this pull request Feb 18, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2024 •
edited

Test Results

0 files   -   214  0 suites   - 214   0s ⏱️ - 22m 41s
0 tests  -   665  0 ✅  -   655  0 💤  - 10  0 ❌ ±0 
0 runs   - 1 330  0 ✅  - 1 308  0 💤  - 22  0 ❌ ±0 

Results for commit 195f29e. ± Comparison against base commit a680216.

♻️ This comment has been updated with latest results.

@G-Ork G-Ork force-pushed the Unified_UI_Setting_for_Toolchains branch from df11ec9 to 7f2d136 Compare March 20, 2024 15:58
@G-Ork G-Ork force-pushed the Unified_UI_Setting_for_Toolchains branch from 7f2d136 to 195f29e Compare March 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@G-Ork