Use 32-bit XOR to zero registers in x64 #19320
Conversation
R2steven
changed the title
There was a problem hiding this comment.
Looks good. I found two missing cases in AMD64JNILinkage.cpp
|
Thanks @BradleyWood, I wasn't sure whether the x/amd64 folder was meant to generate code to run on an x86 machine. I also noticed a PXORRegReg instruction in J9TreeEvaluator.cpp. Do you happen to know if this instruction is already 32 bit, or is it 64 bit and I should look into optimizing it? |
No, that is a vector instruction and wouldn't apply to this issue. @0xdaryl Can you launch a build? |
|
Jenkins test sanity xlinux,win,xmac jdk21 |
|
@0xdaryl Failures are infrastructure related |
|
Changes appear fine. Please squash your commits. |
Swept through x86 codegen and replaced XORRegReg with XOR4RegReg when used to zero a register Fix missing cases in AMD64JNILinkage converted XORRegReg() to XOR4RegReg in AMD64JNILinkage.cpp closes eclipse-openj9#19236 Signed-off-by: Ryan Stevens <restevens52@gmail.com>
|
Jenkins test sanity xlinux,win,xmac jdk21 |
|
failures appear to be infrastructure related again. |
|
Windows testing succeeded. Linux and Mac still afflicted by UNB outage. Changes look safe to me. |
|
@R2steven If you are interested, we have a similar issue in eclipse/omr#7295 |
Swept through x86 codegen and replaced XORRegReg with XOR4RegReg when used to zero a register
Closes #19236
Signed-off-by: Ryan Stevens restevens52@gmail.com