Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the e4 view created by PDE template closable #196

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Jul 1, 2022

The currently contributed part is not closable which is not a typical
behavior for contributed parts.

@vogella
Copy link
Contributor Author

vogella commented Jul 1, 2022

Do we have a freeze day today? I did not see an email for that.

@vogella
Copy link
Contributor Author

vogella commented Aug 9, 2022

@laeubi something seems wrong with the new API parser, works fine on GH action for Ubuntu but not on Windows.

@laeubi
Copy link
Contributor

laeubi commented Aug 9, 2022

This sadly is an issue with:

so let the peoples there know this is an issue and ask for a fix :-)

@vogella
Copy link
Contributor Author

vogella commented Aug 9, 2022

This sadly is an issue with:

so let the peoples there know this is an issue and ask for a fix :-)

Not sure what the exact issue is, so I leave that to you as you worked on this. Maybe we should disable the verifcation GH build on Windows until this is fixed?

@laeubi
Copy link
Contributor

laeubi commented Aug 9, 2022

Not sure what the exact issue is, so I leave that to you as you worked on this. Maybe we should disable the verifcation GH build on Windows until this is fixed?

This currently only affects the upload of the test results, so I think it is still useful.

@HannesWell
Copy link
Member

What's the status here? Can this be submitted?

@github-actions
Copy link

github-actions bot commented Jan 28, 2023

Test Results

     80 files       80 suites   15m 28s ⏱️
3 276 tests 2 903 ✔️ 24 💤 349
3 375 runs  3 002 ✔️ 24 💤 349

For more details on these failures, see this check.

Results for commit 0fd676e.

♻️ This comment has been updated with latest results.

The currently contributed part is not closable which is not a typical
behavior for contributed parts.
@vogella
Copy link
Contributor Author

vogella commented Jan 30, 2023

What's the status here? Can this be submitted?

Yes, IIRC tests were failing before but I think these were unrelated.

@merks
Copy link
Contributor

merks commented Jan 30, 2023

I think normally there were 349 tests failing...

@akurtakov
Copy link
Member

Just the "usual" test failures.

@akurtakov akurtakov merged commit 9d76929 into master Feb 2, 2023
@akurtakov akurtakov deleted the pde-view branch February 2, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants