UiSession: fix theme initialization #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschwarzent
force-pushed
the
features/bschwarzent/24.2/270127_init_ui_theme
branch
from
22a8c00
to
9989bbe
Compare
fschinkel
requested changes
May 14, 2024
bschwarzent
force-pushed
the
features/bschwarzent/24.2/270127_init_ui_theme
branch
from
9989bbe
to
c809521
Compare
fschinkel
approved these changes
May 14, 2024
- URL param (?theme=xyz) always takes precedence over the current theme - Otherwise, if the model already has a theme set, use that one. - Otherwise, use the "current theme" from the request (session attribute, cookie or default value). A warning is only logged when the requested theme or the model theme is set but is not valid according to UiThemeHelper. When the model does not specify a theme, a default theme is assigned automatically without log message. When the theme is determined, it is written back to the model, so the logo URL and potentially other things can be adjusted. In Scout JS, we have no UiSession or ClientSession. For a similar functionality, the URL param is manually compared with the current theme (called "active theme"). 270127
bschwarzent
force-pushed
the
features/bschwarzent/24.2/270127_init_ui_theme
branch
from
c809521
to
ab45107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning is only logged when the requested theme or the model theme is set but is not valid according to UiThemeHelper. When the model does not specify a theme, a default theme is assigned automatically without log message.
When the theme is determined, it is written back to the model, so the logo URL and potentially other things can be adjusted.
In Scout JS, we have no UiSession or ClientSession. For a similar functionality, the URL param is manually compared with the current theme (called "active theme").
270127