DynamicResourceLoader: allow internal loading of binary resources #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds methods to DynamicResourceLoader and DynamicResourceInfo to allow loading of a BinaryResource internally, using the URL but without requiring a HTTP request. 329612
fschinkel
requested changes
Mar 25, 2024
| * @param path | ||
| * decoded path (non url-encoded) | ||
| */ | ||
| public static DynamicResourceInfo fromPath(Function<String/*uiSessionId*/, IUiSession> uiSessionResolver, Function<String/*id*/, IJsonAdapter> jsonAdapterResolver, String path) { |
There was a problem hiding this comment.
uiSessionResolver is not really used. It is called and the result is validated (matching ids), but the resulting IUiSession is not used. Therefore, delete the parameter or use it to validate the IJsonAdapter.
| } | ||
| // resolve session id and adapter id | ||
| IUiSession uiSession = Optional.ofNullable(parts.getUiSessionId()).map(uiSessionResolver).orElse(null); | ||
| IJsonAdapter jsonAdapter = Optional.ofNullable(parts.getAdapterId()).map(jsonAdapterResolver).orElse(null); |
There was a problem hiding this comment.
call jsonAdapterResolver after validating the uiSession
| return localResourceHolder.get(); | ||
| } | ||
|
|
||
| protected static IBinaryResourceProvider getBinaryResourceProvider(IUiSession uiSession, String adapterId) { |
There was a problem hiding this comment.
Please do not change this to static on a released version as it might break existing projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods to DynamicResourceLoader and DynamicResourceInfo to allow loading of a BinaryResource internally, using the URL but without requiring a HTTP request.
329612