DatePicker: fix scroll direction of mouse wheel #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 719bddb the mouse wheel listener of the DatePicker was changed from the legacy 'mousewheel' event to the modern 'wheel' event. Unfortunately, the sign of the scroll unit is different for these two event types [1]. The delta values in the new 'wheel' event indicate the scroll amount [2], i.e. positive numbers mean scroll down/right, while negative numbers mean scroll up/left. To restore the previous behavior of the date picker, the sign of the 'diff' value has to be adjusted accordingly. [1] https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event [2] https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event 379013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 719bddb the mouse wheel listener of the DatePicker was changed from the legacy 'mousewheel' event to the modern 'wheel' event. Unfortunately, the sign of the scroll unit is different for these two event types [1]. The delta values in the new 'wheel' event indicate the scroll amount [2], i.e. positive numbers mean scroll down/right, while negative numbers mean scroll up/left.
To restore the previous behavior of the date picker, the sign of the 'diff' value has to be adjusted accordingly.
[1] https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event
[2] https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event
379013