Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of unsupported language features #3730

Closed
thegecko opened this issue Dec 4, 2018 · 3 comments
Closed

Remove usage of unsupported language features #3730

thegecko opened this issue Dec 4, 2018 · 3 comments
Labels
electron issues related to the electron target

Comments

@thegecko
Copy link
Member

thegecko commented Dec 4, 2018

As discussed in #3693 and in the dev meeting, we are using some language features which aren't supported in electron<3.

Specifically there are instances of Array.values() in (at least) the debug plugin which should be removed.

According to node.green all other ES2015 language features are supported by our current target runtimes.

It would also be extremely useful to include checks to avoid using unsupported language features in future (via tslint, node, or @types/node versions perhaps?).

@thegecko thegecko added the electron issues related to the electron target label Dec 4, 2018
@thegecko
Copy link
Member Author

thegecko commented Dec 4, 2018

@akosyakov Is this something you wanted to look into?

@akosyakov
Copy link
Member

@thegecko I can have a look into fixing the debug extension.

Someone else can have a look into the rest, like adding checks or 3rd party polyfills if there is no way to check.

There are 2 more things come to my mind:

  • if we introduce checks we should also generate them in the Theia extension generator that external extensions don't use these features as well.
  • @simark wanted to switch from es6 to es7 (esnext) libs, but now I am not sure whether it is a good idea since we have problems even with es6.

@thegecko
Copy link
Member Author

I believe this is no longer an issue since our move to Electron 3/node 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
None yet
Development

No branches or pull requests

2 participants