Electron 3 rebased and updated tests #4748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Moran <rob.moran@arm.com> Fix node 10 AddressInfo type change Signed-off-by: Rob Moran <rob.moran@arm.com> Fix electron scroll options change Signed-off-by: Rob Moran <rob.moran@arm.com>
Signed-off-by: Mathieu Debove <debovemathieu@gmail.com>
debovema
force-pushed
the
electron-3-tests
branch
from
d4990fb
to
15e1123
Compare
thegecko
force-pushed
the
electron-3
branch
6 times, most recently
from
8add844
to
2aa851c
Compare
|
Only just seen this PR. Does it add anything not captured in #4750 ? |
|
Nope. It was mainly a rebase from master to tentatively run the tests (some behave better after rebase but not all pass) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.