WebSocket connection #5191
Merged
WebSocket connection #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
websocket-connection
branch
4 times, most recently
from
1b8c780
to
c195e2f
Compare
vietj
force-pushed
the
websocket-connection
branch
from
2858ed5
to
2837210
Compare
Move WebSocket related code from `Http1xConnectionBase` to its own `ConnectionBase` subclass in order to simplify `Http1xConnectionBase` and ease its maintenance. The WebSocket connection has now its own Netty handler instead of relying on the HTTP/1.x handler. The HTTP/1.x handler now does not need to take in account WebSocket frames and WebSocket state. Simplify server WebSocket code by moving the code related to WebSocket accept/reject API to a WebSocket implementation that proxies an accepted `WebSocket` using the same approach than `ClientWebSocket`
vietj
force-pushed
the
websocket-connection
branch
from
2837210
to
24c1113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal refactor of the WebSocket connection implementation
Http1xConnectionBaseto its ownConnectionBasesubclass in order to simplifyHttp1xConnectionBaseand ease its maintenance. The WebSocket connection has now its own Netty handler instead of relying on the HTTP/1.x handler. The HTTP/1.x handler now does not need to take in account WebSocket frames and WebSocket state.WebSocketusing the same approach thanClientWebSocket