Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP client updates #88

Merged
merged 1 commit into from
May 31, 2024
Merged

HTTP client updates #88

merged 1 commit into from
May 31, 2024

Conversation

vietj
Copy link
Member

@vietj vietj commented Feb 12, 2024

The gRPC client builds its own HTTP client. Since the HTTP client got new capabilities (service name resolution, unpooled connections), it makes sense to allow wrapping an existing HTTP client interface.

Modify the gRPC client to allow wrapping an existing HTTP client interface.

… new capabilities (service name resolution, unpooled connections), it makes sense to allow wrapping an existing HTTP client interface.

Modify the gRPC client to allow wrapping an existing HTTP client interface.
@vietj vietj added this to the 5.0.0 milestone Feb 12, 2024
@vietj
Copy link
Member Author

vietj commented Feb 12, 2024

FYI @tsegismont this updates the gRPC client to allow using an HttpClient since the HttpClientConnection PR has been merged

@vietj vietj merged commit f806222 into main May 31, 2024
4 checks passed
@vietj vietj deleted the update-grpc-client-to-use-http-client branch May 31, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant