Preferred server type connection factory #1064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-vertx#963 In particular, ODBC_ON implies ANSI_DEFAULTS which activates the following ISO behaviors: - ANSI_NULLS - CURSOR_CLOSE_ON_COMMIT - ANSI_NULL_DFLT_ON - IMPLICIT_TRANSACTIONS - ANSI_PADDING - QUOTED_IDENTIFIER - ANSI_WARNINGS Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Davide D'Alto <davide@hibernate.org>
Signed-off-by: Davide D'Alto <davide@hibernate.org>
Signed-off-by: Davide D'Alto <davide@hibernate.org>
Signed-off-by: Mark Swatosh <mark.swatosh@gmail.com>
Fixes eclipse-vertx#977 LocalTime, LocalDateTime and OffsetDateTime have nanosecond precision. Also, the maximum scale in MSSQL is 7 (hundreds of nanos). So when encoding time-related values, we will always send a value with maximum scale. The server will do round/truncate as necessary. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
See eclipse-vertx#983 Temporarily disabling in order to let CI deploy snaphots of clients Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
* Implement batch queries for MSSQL Client Closes eclipse-vertx#607 Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Tracing tests are now fully passing Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Moving all encoding, decoding, and metadata parsing logic to the same class. Also, put common buffer modification methods to utility Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
…x#988) * Allow to configure SQL Server container with a fixed port This simplifies debugging with tools like wireshark. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Allow to configure PostgreSQL Server container with a fixed port This simplifies debugging with tools like wireshark. Signed-off-by: Thomas Segismont <tsegismont@gmail.com> * Update documentation Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Removes overhead of looking up value while no specific behavior is attached to it. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Removes overhead of looking up value while no specific behavior is attached to it. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Removes overhead of looking up value while no specific behavior is attached to it. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
…type-connection-factory
Rattenkrieg
changed the title
|
Hey @vietj any chance you could have a look? |
|
sure @Rattenkrieg |
|
the new server type and requirements are specific to PG and the selection code should be in vertx-pg-client instead of vertx-sql-client |
|
it seems that this specific mechanism should be used as a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to specify required/preferred server type among multiple servers when several hosts provided to pool factory.
Example:
Similar functionality provided by pgjdbc via targetServerType and libpq via target_session_attrs.