New Pull Request for EVA signature #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ECA works, YAAAY |
erikbosch
reviewed
Mar 18, 2024
| @@ -17,7 +17,6 @@ Name | Description | |||
| * [SOME/IP Provider](https://github.com/eclipse-kuksa/kuksa-someip-provider) | |||
| * [DDS Provider](https://github.com/eclipse-kuksa/kuksa-dds-provider) | |||
| * [CSV Provider](https://github.com/eclipse-kuksa/kuksa-csv-provider) | |||
| * [eCAL Provider](https://github.com/eclipse-kuksa/kuksa-incubation/tree/main/ecal2val) | |||
There was a problem hiding this comment.
I assume this is a merge conflict error, i.e. that it is not intentional to remove this line?
erikbosch
reviewed
Mar 18, 2024
| @@ -7,7 +7,7 @@ | |||
| Name | Description | |||
| ---- | ----------- | |||
| [Replay](./replay) |[KUKSA Server](https://github.com/eclipse/kuksa.val/tree/master/kuksa-val-server) replay script for previously recorded files, created by running KUKSA Server with `--record` argument **Note: Replay is deprecated and will reach End-of-Life 2024-12-31!** | |||
| [ecal2val](./ecal2val) |Provider for eCAL data to [KUKSA Databroker](https://github.com/eclipse/kuksa.val/tree/master/kuksa_databroker) | |||
| [fone2val](./fone2val) | F1 Telemetrydata source for [KUKSA Databroker](https://github.com/eclipse/kuksa.val/tree/master/kuksa_databroker) | |||
There was a problem hiding this comment.
Here removing the ecal2val line is fine as I better should have removed it in last commit
erikbosch
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Looks good to me.
There is some minor things which I believe is merge conflict regressions in main README but I do not see that as necessary as fix before merge as I anyway will need to update the README in the planned move of the content of this PR after merge to https://github.com/eclipse-kuksa/kuksa-incubation (as we are about to archive this repo)
SebastianSchildt
approved these changes
Mar 19, 2024
erikbosch
added a commit
to boschglobal/kuksa-incubation
that referenced
this pull request
Mar 20, 2024
Previously in https://github.com/eclipse/kuksa.val.feeders/tree/main/fone2val Original PR: eclipse/kuksa.val.feeders#172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I now have checked the email, unset and set it again and i hope everything is set up properly now.