Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec prom output #690

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Spec prom output #690

merged 3 commits into from
Aug 4, 2022

Conversation

donbourne
Copy link
Member

fixes #678

  • full update of prometheus text based exposition format output section
  • removes details that may vary across implementations
  • includes details about how to map from Gauge, Counter, Timer, Histogram to the prometheus format

@donbourne
update prometheus format section
4b66f47 
Signed-off-by: Don Bourne <dbourne@ca.ibm.com>
@donbourne
fix copyright year
13d24b1 
Signed-off-by: Don Bourne <dbourne@ca.ibm.com>
tjquinno
tjquinno reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the question double-checking about underscores in built-in scope names in the output.

@donbourne
fix scope label
6ab56b4 
Signed-off-by: Don Bourne <dbourne@ca.ibm.com>
@donbourne donbourne merged commit 1e6cf8d into eclipse:master Aug 4, 2022
@donbourne donbourne deleted the spec_prom_output branch August 4, 2022 21:53
@donbourne donbourne mentioned this pull request Aug 4, 2022
Closed
@Channyboy Channyboy mentioned this pull request Aug 5, 2022
Merged
@Channyboy Channyboy added this to the 5.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

SPEC: clarify what output format we require for /metrics
3 participants
@donbourne @tjquinno @Channyboy