Fix collection of object files for omr_static_lib #7177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested review from
charliegracie,
mstoodle and
0xdaryl
as code owners
|
The commit message is missing the details from the PR description. |
babsingh
reviewed
Nov 13, 2023
The details/justification from #7177 (comment) should be included in the commit message's body, which is currently empty. |
The behavior of GNU make seems to have changed between versions 4.2.1 and 4.3. The latter appears to prioritize MAKEFLAGS= over (at least some) command-line options, with the effect being that --no-print-directory is ignored and included in the output of show-objects. If invoked as part of a larger build where the make job server is enabled, there are also warnings that make unwanted contributions to the output of show-objects. This fixes that, and removes the useless "echo" rule for the already existing objects. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Fixed in 9cf7484. |
|
jenkins build all |
|
In addition to a known failure (#6516), I see multiple occurrences of the below error: The undocumented error is seen in other builds and unrelated to the changes in this PR. |
|
Opened #7181 for the undocumented failure mentioned in #7177 (comment). |
babsingh
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of GNU make seems to have changed between versions 4.2.1 and 4.3.
The latter appears to prioritize
MAKEFLAGS=over (at least some) command-line options, with the effect being that--no-print-directoryis ignored and included in the output ofshow-objects.If invoked as part of a larger build where the make job server is enabled, there are also warnings that make unwanted contributions to the output of
show-objects.This fixes that, and removes the useless "echo" rule for the already existing objects.