Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86: Enable dual TLH by default #7234

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BradleyWood
Copy link
Member

No description provided.

Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
@vijaysun-omr
Copy link
Contributor

I would appreciate a review from @0xdaryl on this to make sure we have considered what we need to, before making this change

@vijaysun-omr
Copy link
Contributor

I would also advise a small unit test in this case where you have an allocation of each kind, one that needs zeroing and one that does not, and check the generated code sequences to make sure that it is all as expected (i.e. we use the two TLHs in the expected way).

@vijaysun-omr
Copy link
Contributor

Also FYI, @mpirvu for any memory footprint impacts

@vijaysun-omr
Copy link
Contributor

I am only approving the fact that the enablement looks okay. I'll wait for Daryl's review and run tests.

@vijaysun-omr
Copy link
Contributor

jenkins build all

@BradleyWood
Copy link
Member Author

MacOS failure is #7181

Windows Failed due to:

ChannelClosedException: Channel "hudson.remoting.Channel@4b2b57a4:win2019x64-openj9-2": Remote call on win2019x64-openj9-2 failed. The channel is closing down or has closed down

@knn-k
Copy link
Contributor

knn-k commented Feb 16, 2024

Dual TLH is disabled by default on AArch64 now. PR #7243.

@vijaysun-omr
Copy link
Contributor

Is batch clearing enabled by default on AArch64 ? If not, is it being considered to be enabled by default ?

@knn-k
Copy link
Contributor

knn-k commented Feb 16, 2024

@vijaysun-omr TLH batch clearing is enabled by default on AArch64. See my comment in eclipse-openj9/openj9#18870 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants