Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not simplify lsub trees if its grandchild can overflow #7235

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Do not simplify lsub trees if its grandchild can overflow #7235

merged 1 commit into from
Jan 19, 2024

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Jan 19, 2024

Do not simplify lsub trees if its grandchild can overflow

@a7ehuo
Do not simplify lsub trees if its grandchild can overflow
03408a6 
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo requested a review from jdmpapin January 19, 2024 15:21
@a7ehuo a7ehuo mentioned this pull request Jan 19, 2024
Merged
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Jan 19, 2024

x86-64 macOS test failure is a known issue #7181

2024-01-19T15:41:40.9187250Z 9: Test command: /Users/runner/work/1/s/build/jitbuilder/release/worklist
2024-01-19T15:41:40.9187950Z 9: Working Directory: /Users/runner/work/1/s/build/jitbuilder/release
2024-01-19T15:41:40.9188750Z 9: Test timeout computed to be: 10000000
2024-01-19T15:41:40.9189600Z  7/49 Test  #2: TestJitBuilderAPIGenerator ..........***Failed    1.34 sec

@jdmpapin jdmpapin self-assigned this Jan 19, 2024
@jdmpapin jdmpapin removed their assignment Jan 19, 2024
@vijaysun-omr
Copy link
Contributor

Conservative change, looks safe to me

@vijaysun-omr
Copy link
Contributor

jenkins build all

@vijaysun-omr
Copy link
Contributor

Tests have passed, except for known macOS failure

@vijaysun-omr vijaysun-omr merged commit 6b7a87a into eclipse:master Jan 19, 2024
16 of 18 checks passed
@a7ehuo a7ehuo deleted the tree-simplifier-isub-pr branch March 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysun-omr vijaysun-omr vijaysun-omr approved these changes

@jdmpapin jdmpapin Awaiting requested review from jdmpapin

Assignees
No one assigned
Labels
comp:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a7ehuo @vijaysun-omr @jdmpapin