Initial changes for Open XL z/os support #7320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
reviewed
Apr 25, 2024
thread/common/thrprof.c
Outdated
Comment on lines
472
to
477
| uintptr_t *tempHandle; | ||
| tempHandle = (uintptr_t *)&(thread->handle.__[0]); | ||
| #if defined(__GNUC__) | ||
| tempHandle = (uintptr_t *)&(thread->handle.__); | ||
| #else | ||
| tempHandle = (uintptr_t *)&(thread->handle.__[0]); | ||
| #endif |
There was a problem hiding this comment.
This should use the same pattern as in #7323.
There was a problem hiding this comment.
So I am seeing https://github.com/Deigue/omr/blob/4401fae20ac9db1255fafb68333e322297d43620/include_core/thrtypes.h#L57 , handle is of type OSTHREAD
OSTHREAD tempHandle = thread->handle;
return (uint_ptr)* <cast> tempHandle
But what would the cast look like? Where can I find OSTHREAD to see what exactly __ is pulling out and how to cast it properly? "handle" also seemed like too broad a search/grep for /usr/include
There was a problem hiding this comment.
Something like this is what I meant:
OSTHREAD tempHandle = thread->handle;
return (uintptr_t)*(unsigned long long *)&tempHandle;For z/OS, OSTHREAD is defined in include_core/unix/thrdsup.h:
typedef pthread_t OSTHREAD;There was a problem hiding this comment.
Thanks, confirmed it works and everything compiles, and changed accordingly.
Includes all the initial work done a while ago made in order to support compiling with Open XL in context of z/OS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all the initial work done a while ago made in order to support compiling with Open XL in context of z/OS.
(This is one part of the multiple changes added for supporting Open XL compilation on OMR)