Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for http/https proxy when using MQTT over websockets #322

Merged
merged 4 commits into from Jun 28, 2019

Conversation

reubenmiller
Copy link
Contributor

Summary

Switching websockets package to gorilla/websocket as it has support for http proxies and the package is maintained more frequently than golang.org/x/net/websocket.

When using either ws:// or wss:// connections, the http proxy settings can be set via the following standard environment variables.

  • HTTP_PROXY
  • HTTPS_PROXY
  • NO_PROXY

…y can be supported

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the gorilla-websockets branch 3 times, most recently from b66b063 to c13d050 Compare June 24, 2019 06:47
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@alsm
Copy link
Contributor

alsm commented Jun 28, 2019

Thanks for this, really useful.

@alsm alsm merged commit 0d81c29 into eclipse:master Jun 28, 2019
@iwittkau
Copy link

This is indeed really useful!
Are there any plans on releasing a new version including this PR @alsm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants