Refactor of net (and related client) functions #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major refactor of net.go, significant parts of client, and a few other small changes, in an attempt to seperate out network code, simplify msg flows and reduce the chance (and need for mitagations for) deadlocks. Aims to be non-breaking from users perspective. This is an initial pull request for review; it passes the existing tests but will need more testing. Submitting it to see if there is an appetite for this level of change and agreement on whether the changes add value. closes 372 Signed-off-by: Matt Brittan <matt@brittan.nz>
|
hope for merge~ |
Closed
|
Thanks for all your work on this. |
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor of net.go, significant parts of
client, and a few other small changes, in an
attempt to seperate out network code, simplify msg
flows and reduce the chance (and need for mitagations
for) deadlocks. Aims to be non-breaking from users
perspective.
This is an initial pull request for review; it passes
the existing tests but will need more testing. Submitting
it to see if there is an appetite for this level of change
and agreement on whether the changes add value.
closes 372
Signed-off-by: Matt Brittan matt@brittan.nz