Remove mu Lock from WaitTimeOut #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the mutex is also locked in SetError this caused WaitTimeOut to always wait until the timer expired in the case of an error. As WaitTimeOut does not access any struct members other than the pipe I see no reason to lock the mutex (it appears to data back from when an struct var , .ready, was accessed). closes #40 Signed-off-by: Matt Brittan <matt@brittan.nz>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the mutex is also locked in SetError this
caused WaitTimeOut to always wait until the timer
expired in the case of an error.
As WaitTimeOut does not access any struct members
other than the pipe I see no reason to lock the
mutex (it appears to data back from when an struct var
, .ready, was accessed).
closes #382
Signed-off-by: Matt Brittan matt@brittan.nz