client: verify payload of SubscribeMultiple is not empty #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbawebba
commented
Nov 16, 2019
MQTT protocol 3.1.1 specifies that the payload in a SUBSCRIBE packet must not be empty and must contain at least one topic filter and QoS pair. Validate the input to SubscribeMultiple meets this requirement to avoid protocol errors when communicating with a broker. Fixes eclipse#384 Signed-off-by: Robert Weber <robertweber95@gmail.com>
robbawebba
force-pushed
the
fix/SubscribeMultiple-empty-filter
branch
from
6952317
to
ca5affb
Compare
|
Thanks |
|
@MattBrittan @alsm I also ran into this issue, but when I accidentally published to an empty topic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTT protocol 3.1.1 specifies that the payload in a SUBSCRIBE packet
must not be empty and must contain at least one topic filter and QoS
pair. Validate the input to SubscribeMultiple meets this requirement to
avoid protocol errors when communicating with a broker.
Fixes #384
Signed-off-by: Robert Weber robertweber95@gmail.com