Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code consitency fixes #407

Merged
merged 8 commits into from Apr 30, 2020
Merged

Code consitency fixes #407

merged 8 commits into from Apr 30, 2020

Commits on Mar 12, 2020

  1. add go.mod and go.sum to enable module integration 

    Signed-off-by: thomas-tacquet <thomas@tacquet.net>
    @thomas-tacquet
    thomas-tacquet committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    4eaf5dc View commit details
    Browse the repository at this point in the history

  2. fixed go.mod package path due to fork 

    Signed-off-by: thomas-tacquet <thomas@tacquet.net>
    @thomas-tacquet
    thomas-tacquet committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    19788dd View commit details
    Browse the repository at this point in the history

  3. fixed error names, see : https://github.com/golang/go/wiki/CodeReview… 

    …Comments#error-strings

Signed-off-by: thomas-tacquet <thomas@tacquet.net>
    @thomas-tacquet
    thomas-tacquet committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    c1630ab View commit details
    Browse the repository at this point in the history

  4. reciever name consistency 

    Signed-off-by: thomas-tacquet <thomas@tacquet.net>
    @thomas-tacquet
    thomas-tacquet committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    ce67a00 View commit details
    Browse the repository at this point in the history

  5. empty slice remplaced by nil slice, because emptiness was not wanted … 

    …in those cases

Signed-off-by: thomas-tacquet <thomas@tacquet.net>
    @thomas-tacquet
    thomas-tacquet committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    ccaf2de View commit details
    Browse the repository at this point in the history

  6. redundant conversions 

    Signed-off-by: thomas-tacquet <thomas@tacquet.net>
    @thomas-tacquet
    thomas-tacquet committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    115120d View commit details
    Browse the repository at this point in the history

  7. avoid name collision 

    Signed-off-by: thomas-tacquet <thomas@tacquet.net>
    @thomas-tacquet
    thomas-tacquet committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    7e9e9be View commit details
    Browse the repository at this point in the history

  8. go.mod and go.sum has to be in an other PR 

    Signed-off-by: thomas-tacquet <thomas@tacquet.net>
    @thomas-tacquet
    thomas-tacquet committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    07861f1 View commit details
    Browse the repository at this point in the history