Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve potential deadlocks on Resume/Error #434

Merged
merged 2 commits into from Sep 18, 2020
Merged

Resolve potential deadlocks on Resume/Error #434

merged 2 commits into from Sep 18, 2020

Commits on Jun 28, 2020

  1. Resolve deadlock on Resume 

    If the connection was lost while a resume was in progress
a deadlock occured. There was also a chance of a deadlock if an error
occured when sending the response to an inbound packet (e.g. an ACK).
This commit also tidies up a few things (mainly logging).
Signed-off-by: Matt Brittan <matt@brittan.nz>
    @MattBrittan
    MattBrittan committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    38e9a73 View commit details
    Browse the repository at this point in the history

  2. disconnect only cleanup when commsworkers stopped 

    Signed-off-by: Matt Brittan <matt@brittan.nz>
    @MattBrittan
    MattBrittan committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    6a43541 View commit details
    Browse the repository at this point in the history