Propagate MQTT connect error (fixes #356) #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokhanovskyi
force-pushed
the
fix-356
branch
2 times, most recently
from
f55367d
to
521ba18
Compare
Signed-off-by: Andrew Kokhanovskyi <a.kokhanovskyi@gmail.com>
akokhanovskyi
force-pushed
the
fix-356
branch
from
521ba18
to
bda970e
Compare
Signed-off-by: Andrew Kokhanovskyi <a.kokhanovskyi@gmail.com>
|
Updated to keep up to speed with the current master |
|
Thanks for the work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #404 is in conflict with the master, so this is a new fix for #356. Along with accurately propagating an MQTT connect error, multiple golangci-lint errors are fixed (only in the
net.goto reduce the PR size).Signed-off-by: Andrew Kokhanovskyi a.kokhanovskyi@gmail.com