Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential deadlock in matchAndDispatch #470

Merged
merged 1 commit into from Dec 20, 2020

Conversation

MattBrittan
Copy link
Contributor

matchAndDispatch was sending to client.oboundP which created a potential deadlock (in rare situations). This change brings control of the matchAndDispatch lifecycle under stopCommsWorkers (removes the use of the client.outboundp channel) which should ensure a managed shutdown (with any outstanding ACK messages transmitted if possible).

@MattBrittan MattBrittan merged commit 5695029 into eclipse:master Dec 20, 2020
MattBrittan added a commit to ChIoT-Tech/paho.mqtt.golang that referenced this pull request Dec 21, 2020
This issue was picked up when running the tests multiple times (seemed to happen 1/10 ot the time)
MattBrittan added a commit that referenced this pull request Dec 21, 2020
Resolve issue introduced in pull request #470 (missing continue).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant