Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order matters Ack on QoS > 0 #504

Closed
wants to merge 1 commit into from
Closed

Order matters Ack on QoS > 0 #504

wants to merge 1 commit into from

Commits on May 5, 2021

  1. Changed the way to end ack on order matters disabled. 

    So I noticed when using orders matters, if some of the
subscribred clients send messages with a Quality of Service (QoS) > 0
with slow callbacks, if you close the connexion before callbacks ends,
m.Ack() will be called after the connexion has been closed, leading to sending
message on a closed channel on file net.go, function 'ackFunc' line 451 for QoS 2
or line 458 for QoS1.

So I moved m.Ack() outside the routine, so clients will be notified by Ack (because paho
has correctly recieved the QoS ACK) it's paho's job, but ACK will send even if the callback
did not finished.
    @thomas-tacquet
    thomas-tacquet committed May 5, 2021
    Configuration menu
    Copy the full SHA
    e876d13 View commit details
    Browse the repository at this point in the history