Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX-#2327] Revert deletion of hide css class in process of angular upgrade #2330

Conversation

stanisev
Copy link
Contributor

@stanisev stanisev commented May 3, 2024

Reverting back .hide css class, since delete button should be displayed only when an item is hovered and hidden and not all the time.

…e button should be displayed only when an item is hovered and hidden
@CLAassistant
Copy link

CLAassistant commented May 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit ed6291d
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/66355458614e4d0008d14deb
😎 Deploy Preview https://deploy-preview-2330--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sdirix sdirix requested a review from lucas-koehler May 8, 2024 09:04
@coveralls
Copy link

Coverage Status

coverage: 83.347%. remained the same
when pulling ed6291d on stanisev:fix/#2327-revert-hide-css-deletion
into 718aba0 on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix ❤️

@lucas-koehler lucas-koehler merged commit 5c5a470 into eclipsesource:master May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The delete button should be displayed only when an item is hovered and hidden
4 participants