-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/upgrade angular 18 #2337
Feature/upgrade angular 18 #2337
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b35a91f
to
6a747d9
Compare
6a747d9
to
b02ef82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @laurentgrangier, on a first look all changes look reasonable to me 👍
Will you also take a look at why the CI build is failing? It seems it can't execute the Angular Material tests.
It should be now OK. The tests couldn't be built because of a lint "fix" I made :-) |
@laurentgrangier Thanks for the updates. Let's wait until the official release of Angular 18 and adapt this PR to reference it before we merge it :) |
Hi @laurentgrangier , the changes look good to me. I opened a new PR superseding this one at #2340. There I added the released Angular 18 dependency and regenerated the pnpm lock file. Thanks for your work on this ❤️ |
No description provided.