Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade angular 18 #2337

Conversation

laurentgrangier
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 0f15451
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/664749200da9670008c8cd3b
😎 Deploy Preview https://deploy-preview-2337--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@laurentgrangier laurentgrangier force-pushed the feature/upgrade-angular-18 branch 2 times, most recently from b35a91f to 6a747d9 Compare May 14, 2024 09:15
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laurentgrangier, on a first look all changes look reasonable to me 👍

Will you also take a look at why the CI build is failing? It seems it can't execute the Angular Material tests.

@coveralls
Copy link

Coverage Status

coverage: 83.322% (-0.03%) from 83.347%
when pulling 0f15451 on codeblock-gmbh:feature/upgrade-angular-18
into 718aba0 on eclipsesource:master.

@laurentgrangier
Copy link
Contributor Author

Will you also take a look at why the CI build is failing? It seems it can't execute the Angular Material tests.

It should be now OK. The tests couldn't be built because of a lint "fix" I made :-)

@lucas-koehler
Copy link
Contributor

@laurentgrangier Thanks for the updates. Let's wait until the official release of Angular 18 and adapt this PR to reference it before we merge it :)

@lucas-koehler lucas-koehler mentioned this pull request May 23, 2024
@lucas-koehler
Copy link
Contributor

Hi @laurentgrangier , the changes look good to me. I opened a new PR superseding this one at #2340. There I added the released Angular 18 dependency and regenerated the pnpm lock file.
I would have pushed this update to this branch but your fork forbids this. I opened a follow up PR because we do not merge regenerated pnpm lock files from outside collaborators. This has nothing to do with you or your company in particular but is a general safety precaution because we cannot reasonably look at all the changes in the lock file for malicious edits.
If you can verify in #2340 that jsonforms works with the Angular 18 release, we will merge the PR and release a new version of JsonForms soon :)

Thanks for your work on this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants