Update android theming docs to reflect cordova 11 change #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpetrov
approved these changes
Jul 4, 2023
doc/theming-android.md
Outdated
|
|
||
| These configuration steps are straight forward with the elements available in the apps `config.xml`. The following excerpt shows how to copy the created _myapp_theme.xml_ via the `<resource-file>` element into the app and to apply it via the `<preference>` element. | ||
| These configuration steps are straight forward with a configuration in the apps `config.xml`. The following excerpt shows how to copy the created _myapp_theme.xml_ via the `<resource-file>` element into the app and to apply it via the `<preference>` element. |
doc/theming-android.md
Outdated
|
|
||
| These configuration steps are straight forward with the elements available in the apps `config.xml`. The following excerpt shows how to copy the created _myapp_theme.xml_ via the `<resource-file>` element into the app and to apply it via the `<preference>` element. | ||
| These configuration steps are straight forward with a configuration in the apps `config.xml`. The following excerpt shows how to copy the created _myapp_theme.xml_ via the `<resource-file>` element into the app and to apply it via the `<preference>` element. |
There was a problem hiding this comment.
"configuration" twice in the same sentence
With the removal of the Tabris.js specific splash screen theming mechanism, the default cordova mechanism is now used. This change updated the docs to reflect those new capabilities. Fixes #2264
mpost
force-pushed
the
android-theming-docs
branch
from
e2c73b2
to
239b723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of the Tabris.js specific splash screen theming mechanism, the default cordova mechanism is now used. This change updated the docs to reflect those new capabilities.
Fixes #2264