Support generating and importing ECDSA keys #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECDSA and ECDH keys have the same internal representation on the native client but are used for different purposes - ECDSA for signing and ECDH for key exchange. This commit adds support for ECDSA keys to the `SubtleCrypto` API. This prepares the way for supporting `crypto.subtle.sign()` and `crypto.subtle.verify()`. It also removes `"ECDH"` from the allowed string values for the `algorithm` parameter of `crypto.subtle.importKey`, because for ECDH and ECDSA algorithms, always an object that includes `namedCurve` must be provided [1]. [1]: https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/importKey
cpetrov
force-pushed
the
pr-ecdsa-keys
branch
from
a24934c
to
e324233
Compare
tbuschto
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECDSA and ECDH keys have the same internal representation on the native client but are used for different purposes - ECDSA for signing and ECDH for key exchange.
This commit adds support for ECDSA keys to the
SubtleCryptoAPI. This prepares the way for supportingcrypto.subtle.sign()andcrypto.subtle.verify().It also removes
"ECDH"from the allowed string values for thealgorithmparameter ofcrypto.subtle.importKey, because for ECDH and ECDSA algorithms, always an object that includesnamedCurvemust be provided 1.master