Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Edam Browser User] Change proposition for http://edamontology.org/operation_3206 #770

Open
vbaillet opened this issue Oct 7, 2021 · 1 comment · May be fixed by #802
Open

[Edam Browser User] Change proposition for http://edamontology.org/operation_3206 #770

vbaillet opened this issue Oct 7, 2021 · 1 comment · May be fixed by #802
Assignees
@LucieLamothe
Labels
concept/term addition Request for a new concept(s), or change(s) to existing concept(s) polishing Does not extend the content or functionality, but improves other qualities

Comments

@vbaillet
Copy link
Contributor

vbaillet commented Oct 7, 2021

Comments

  • tiny change to definition
  • link with topics = epigenetics, epigenomics

Hereafter are the initial version and proposed modification of attributes of the given term

key value
Attr definition
Old Measure the overall level of methyl cytosines in a genome from analysis of experimental data, typically from chromatographic methods and methyl accepting capacity assay.
New Measure the overall level of methylated cytosines in a genome from analysis of experimental data, typically from chromatographic methods and methyl accepting capacity assay.
key value
Attr has_topic-0
Old
New http://edamontology.org/topic_3173
key value
Attr has_topic-1
Old
New http://edamontology.org/topic_3295
@LucieLamothe LucieLamothe self-assigned this Oct 7, 2021
@LucieLamothe LucieLamothe added concept/term addition Request for a new concept(s), or change(s) to existing concept(s) polishing Does not extend the content or functionality, but improves other qualities labels Oct 7, 2021
@matuskalas
Copy link
Member

matuskalas commented Dec 22, 2021 •
edited

In fact, this concept (Whole genome methylation analysis) should be a topic. It is not a step in data analysis, but instead a whole method of research (data generation + the whole analysis workflow).
The suggested parent topics sound good (Epigenetics and Epigenomics), but it's enough with Epigenomics as long as that's under Epigenetics anyway.

This however means that the operation_3206 should be deprecated, "replaced by" a new topic. The latter may cause issues in some annotations, so maybe the best would be another "replaced by" or rather 2x "consider" incl. both its current parents.

LucieLamothe added a commit to LucieLamothe/edamontology that referenced this issue Dec 23, 2021
@LucieLamothe
Deprecated operation_3206 added topic Whole genome methylation analysis
63e0992 
FIX edamontology#770

Co-authored-by: vbaillet vbaillet@noreply.users.github.com
@LucieLamothe LucieLamothe linked a pull request Dec 23, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucieLamothe LucieLamothe

Labels
concept/term addition Request for a new concept(s), or change(s) to existing concept(s) polishing Does not extend the content or functionality, but improves other qualities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecated operation_3206 added topic Whole genome methylation analysis LucieLamothe/edamontology
3 participants
@matuskalas @vbaillet @LucieLamothe