Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polished formating of some links & others #758

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

matuskalas
Copy link
Member

@matuskalas matuskalas commented Sep 11, 2021

a.k.a. "Saturday-night fever"

incl.:

  • Made all links to non-literals (except links to other ontologies. Please keep it like that, so we can find & improve those in the future)
  • Removed inappropriate quotes around links and so
  • All Wikipedia links with https and en.wikipedia.org/wiki/
  • Fixed some property names of some links and so
  • Added missing dots after definitions and comments
  • Fixed a couple of typos

a.k.a. "Saturday-night fever"

incl.:

- Made all links to non-literals (except links to other ontologies)
- Removed inappropriate quotes around links
- All Wikipedia links with https
- Fixed property names of some links
- Added missing dots after definitions and comments
- Fixed a couple of typos
@matuskalas matuskalas added the polishing Does not extend the content or functionality, but improves other qualities label Sep 11, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

<oboInOwl:hasDefinition>One or more protein sequences, possibly with associated annotation.</oboInOwl:hasDefinition>
<oboInOwl:hasExactSynonym>Amino acid sequence</oboInOwl:hasExactSynonym>
<oboInOwl:hasExactSynonym>Amino acid sequences</oboInOwl:hasExactSynonym>
<oboInOwl:hasExactSynonym>Protein sequences</oboInOwl:hasExactSynonym>
<oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#data"/>
<oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#edam"/>
<rdfs:label>Protein sequence</rdfs:label>
<rdfs:seeAlso>http://purl.org/biotop/biotop.owl#AminoAcidSequenceInformation</rdfs:seeAlso>
<rdfs:seeAlso rdf:resource="http://purl.org/biotop/biotop.owl#AminoAcidSequenceInformation"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the temporary "rule" that links to other ontologies stay as literals, this line should be reverted.

<oboInOwl:hasDefinition>Reference-based compression of alignment format</oboInOwl:hasDefinition>
<documentation rdf:resource="http://www.ebi.ac.uk/ena/software/cram-usage#format_specification"/>
<documentation rdf:resource="http://samtools.github.io/hts-specs/CRAMv2.1.pdf"/>
<documentation rdf:resource="http://www.ebi.ac.uk/ena/software/cram-usage#format_specification"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated lines here

<oboInOwl:hasExactSynonym>LaTeX format</oboInOwl:hasExactSynonym>
<oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#edam"/>
<oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#formats"/>
<rdfs:comment>uses the TeX typesetting program format</rdfs:comment>
<rdfs:comment>Uses the TeX typesetting program format.</rdfs:comment>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if there are any other defs or comments starting without a capital

@@ -59882,7 +59889,6 @@ ows re-sequencing of complete genomes of any given organism with high resolution
<owl:Class rdf:about="http://edamontology.org/topic_3674">
<rdfs:subClassOf rdf:resource="http://edamontology.org/topic_3656"/>
<created_in>1.12</created_in>
<documentation rdf:resource="https://en.wikipedia.org/wiki/Whole_genome_sequencing"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check that these last ones are there as seeAlso (not visible in diff)

@matuskalas matuskalas self-assigned this Sep 11, 2021
@matuskalas matuskalas added this to the 1.26 milestone Sep 11, 2021
@matuskalas matuskalas added this to In progress in release 1.26 via automation Sep 11, 2021
@matuskalas matuskalas marked this pull request as draft September 12, 2021 18:55
@@ -54806,7 +54813,7 @@ ows re-sequencing of complete genomes of any given organism with high resolution
<obsolete_since>1.3</obsolete_since>
<oldParent rdf:resource="http://www.w3.org/2002/07/owl#Thing"/>
<oboInOwl:consider rdf:resource="http://edamontology.org/topic_3307"/>
<oboInOwl:hasDefinition>Theoretical biology</oboInOwl:hasDefinition>
<oboInOwl:hasDefinition>Theoretical biology.</oboInOwl:hasDefinition>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of "fake" definitions should be prioritised for improving. Heuristics by length < e.g. 42 chars?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Regex search <oboInOwl:hasDefinition>.{0,41}</oboInOwl:hasDefinition> has unfortunately 488 matches 😥

  • <oboInOwl:hasDefinition>.{0,35}</oboInOwl:hasDefinition> still 311 😓

  • <oboInOwl:hasDefinition>.{0,31}</oboInOwl:hasDefinition> 209 😰

  • and even <oboInOwl:hasDefinition>.{0,23}</oboInOwl:hasDefinition> has 62 matches 😭

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matuskalas
Copy link
Member Author

matuskalas commented Sep 12, 2021

I found some things I want to improve (noted in the diff), so turned to Draft PR for now...

TODO: Right after this is merged, create _unstable, incl. CSV/TSV. For WikiData.

@matuskalas
Copy link
Member Author

I'm going to fix a few more things here, especially distinguishing the links to other ontologies somehow in a nicer way.
In the meantime, please feel free to review / see if any typos left, or additional related weirdnesses to fix... (@LucieLamothe @Kigaard)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority manual merge needed polishing Does not extend the content or functionality, but improves other qualities
Projects
release 1.26
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants