-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polished formating of some links & others #758
base: main
Are you sure you want to change the base?
Conversation
a.k.a. "Saturday-night fever" incl.: - Made all links to non-literals (except links to other ontologies) - Removed inappropriate quotes around links - All Wikipedia links with https - Fixed property names of some links - Added missing dots after definitions and comments - Fixed a couple of typos
Kudos, SonarCloud Quality Gate passed! |
<oboInOwl:hasDefinition>One or more protein sequences, possibly with associated annotation.</oboInOwl:hasDefinition> | ||
<oboInOwl:hasExactSynonym>Amino acid sequence</oboInOwl:hasExactSynonym> | ||
<oboInOwl:hasExactSynonym>Amino acid sequences</oboInOwl:hasExactSynonym> | ||
<oboInOwl:hasExactSynonym>Protein sequences</oboInOwl:hasExactSynonym> | ||
<oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#data"/> | ||
<oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#edam"/> | ||
<rdfs:label>Protein sequence</rdfs:label> | ||
<rdfs:seeAlso>http://purl.org/biotop/biotop.owl#AminoAcidSequenceInformation</rdfs:seeAlso> | ||
<rdfs:seeAlso rdf:resource="http://purl.org/biotop/biotop.owl#AminoAcidSequenceInformation"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the temporary "rule" that links to other ontologies stay as literals, this line should be reverted.
<oboInOwl:hasDefinition>Reference-based compression of alignment format</oboInOwl:hasDefinition> | ||
<documentation rdf:resource="http://www.ebi.ac.uk/ena/software/cram-usage#format_specification"/> | ||
<documentation rdf:resource="http://samtools.github.io/hts-specs/CRAMv2.1.pdf"/> | ||
<documentation rdf:resource="http://www.ebi.ac.uk/ena/software/cram-usage#format_specification"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated lines here
<oboInOwl:hasExactSynonym>LaTeX format</oboInOwl:hasExactSynonym> | ||
<oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#edam"/> | ||
<oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#formats"/> | ||
<rdfs:comment>uses the TeX typesetting program format</rdfs:comment> | ||
<rdfs:comment>Uses the TeX typesetting program format.</rdfs:comment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if there are any other defs or comments starting without a capital
@@ -59882,7 +59889,6 @@ ows re-sequencing of complete genomes of any given organism with high resolution | |||
<owl:Class rdf:about="http://edamontology.org/topic_3674"> | |||
<rdfs:subClassOf rdf:resource="http://edamontology.org/topic_3656"/> | |||
<created_in>1.12</created_in> | |||
<documentation rdf:resource="https://en.wikipedia.org/wiki/Whole_genome_sequencing"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-check that these last ones are there as seeAlso (not visible in diff)
@@ -54806,7 +54813,7 @@ ows re-sequencing of complete genomes of any given organism with high resolution | |||
<obsolete_since>1.3</obsolete_since> | |||
<oldParent rdf:resource="http://www.w3.org/2002/07/owl#Thing"/> | |||
<oboInOwl:consider rdf:resource="http://edamontology.org/topic_3307"/> | |||
<oboInOwl:hasDefinition>Theoretical biology</oboInOwl:hasDefinition> | |||
<oboInOwl:hasDefinition>Theoretical biology.</oboInOwl:hasDefinition> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of "fake" definitions should be prioritised for improving. Heuristics by length < e.g. 42 chars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Regex search
<oboInOwl:hasDefinition>.{0,41}</oboInOwl:hasDefinition>
has unfortunately 488 matches 😥 -
<oboInOwl:hasDefinition>.{0,35}</oboInOwl:hasDefinition>
still 311 😓 -
<oboInOwl:hasDefinition>.{0,31}</oboInOwl:hasDefinition>
209 😰 -
and even
<oboInOwl:hasDefinition>.{0,23}</oboInOwl:hasDefinition>
has 62 matches 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some things I want to improve (noted in the diff), so turned to Draft PR for now... TODO: Right after this is merged, create _unstable, incl. CSV/TSV. For WikiData. |
I'm going to fix a few more things here, especially distinguishing the links to other ontologies somehow in a nicer way. |
a.k.a. "Saturday-night fever"
incl.: