Added format FID, FCF, HKL #820
Conversation
|
Thank you so much for this PR it's good to tackle these issues! 👍 |
|
The 3 added concept seem to be missing parent concept. |
|
I have added the concepts to the 3 formats by commentary. For now, I have used the concept "Chemical data format" to hkl, as there are no x-ray data formats available yet. (I hope this is fine, I couldn't find a better solution.) |
|
Hi @cb2993 , you can simply edit your checked out version, and push that to your branch. This will automagically update the PR to include those changes. Yours, Steffen |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for the tip @sneumann , I have changed it accordingly. |
| <oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#edam"/> | ||
| <oboInOwl:inSubset rdf:resource="http://purl.obolibrary.org/obo/edam#formats"/> | ||
| <oboInOwl:hasDefinition>A flexible tab-delimited reporting data standard file format for sharing quantitative mass spectrometry metabolomics/lipodomics results. It contains the ability to represent “intermediate” or supporting data, including the evidence trail for identifications from software (scores or statistics), as well as the quantification values derived directly from MS: i.e., prior to any adduct grouping or summarization steps. It is an expansion/improvement of mzTab.</oboInOwl:hasDefinition> | ||
| <rdfs:subClassOf rdf:resource=”http://edamontology.org/format_3245”/> |
There was a problem hiding this comment.
There is no need for this format to be subclass of http://edamontology.org/format_3245, because http://edamontology.org/format_3681 is already a subclass of it.
Hi,
As already known, @sneumann and I have looked into chemical data formats on behalf of @NFDI4Chem and want to add the format FID, FCF and HKL.
The issues #787 , #788 , #789 have already been created and herewith the corresponding PR shall be submitted. I have left out the unsafe parts for now.
Yours, Claudia.
(The already submitted format #796 is also included.)