Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background image, highlighter tool #139

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Background image, highlighter tool #139

wants to merge 4 commits into from

Conversation

mehtank
Copy link

@mehtank mehtank commented Jan 4, 2021 •
edited

Additional functionality:

edemaine added a commit that referenced this pull request Feb 9, 2021
@edemaine
Fix CORS and allow OPTIONS for API calls
3c75d5c 
Part of #139

Co-authored-by: mehtank <mehtank>
@edemaine
Copy link
Owner

edemaine commented Feb 9, 2021

FYI, a version of the fix CORS commit (cc45de6) landed in commit 3c75d5c. I fixed the behavior of OPTIONS queries which should not actually run the API call. If you're using your fork, you may want to fix that. Anyway, thanks for the contribution!

This was referenced Apr 21, 2021
Open
Closed
@edemaine edemaine mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehtank @edemaine