Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: nix dev shell #1160

Merged
merged 7 commits into from Mar 7, 2024
Merged

build: nix dev shell #1160

merged 7 commits into from Mar 7, 2024

Conversation

MrFoxPro
Copy link
Contributor

@MrFoxPro MrFoxPro commented Oct 29, 2023

This is my draft for devshell.

It includes:

  • devenv: https://devenv.sh/reference/options
  • edgedb-server bootstrapping (up command)
  • treefmt tool to format whole codebase (alejandra for Nix, rustfmt and shellcheck)
  • direnv's .envrc. You need to install https://direnv.net, so development shell will automatically load whenever you enter directory.

Here I probably needed maintainers assistance @scotttrinh , as I don't known your requirments for this project. If you're interested in this, I can help with configuring it further, we can get calls in edgedb discord, for example.

@aljazerzen
Copy link
Contributor

I need something like this myself, I'd be up for merging it.

I would make it a bit less opinionated - we can use plain mkShell (or the one provided by crane) instead of devenv. direnv also does not need to be required, we can just add .gitignore entry and allow people who want it to set it up themselves.

@MrFoxPro can I take over this effort?

@aljazerzen
Copy link
Contributor

I've published a separate repo for edgedb nix packages here: https://github.com/edgedb/packages-nix

I've also made this PR much less opinionated on tooling and provided only a plain nix shell with minimal tooling. Providing other tooling (such as formatters) is up to individual contributors.

@aljazerzen aljazerzen marked this pull request as ready for review March 7, 2024 14:13
@aljazerzen aljazerzen changed the title chore(nix): Nix devshell draft build: nix dev shell Mar 7, 2024
Copy link
Contributor

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @MrFoxPro and @aljazerzen

@aljazerzen aljazerzen merged commit 743c571 into edgedb:master Mar 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants