Facelift for Queries Generator error logging (#866)

[themajashurka]

Just a little proposal to improve visibility on the outcome of the generator (until a more advanced solution like TAP is implemented)

[edgedb-cla]

All commit authors signed the Contributor License Agreement.

[scotttrinh]

Thanks for jumping in here! Most of my feedback is just formatting and idiom/style things, I like the general shape.

Do you mind also including a screenshot for some review and feedback?

[themajashurka]

Three screenshots for indicating the feature:

Summary of unsuccessful generation at the bottom

Summary of successful generation at the bottom

"Inline error" coloring for unsuccessful generation

[themajashurka]

My latest experience with this change, is that now it feels kind of redundant to print error messages twice: "inline" and aggregated at the bottom. Maybe it's enough to indicate "inline" errors simply with red color (and giving the detailed error in summary)?

Before

After

And one more thing: to reduce messiness, put a separator in between error messages?

[scotttrinh]

@themajashurka

Maybe it's enough to indicate "inline" errors simply with red color (and giving the detailed error in summary)?

Yeah, that looks great!

[scotttrinh]

@themajashurka

And one more thing: to reduce messiness, put a separator in between error messages?

Yeah, either a separator or just a new line works for me, I trust your judgement here.

[themajashurka]

There are still a couple of changes needed to be make in order to make formatError and stuff work. Plus I found an unrelated&small bug.
I'll have more time on the weekend to make these changes!

[themajashurka]

Sorry to ask it here, but is there an industry standard way of keeping a link to my forked edgedb-js in my edgedb projects? I keep jumping back and forth between my forked repo and my local node_modules to see the effect of changes.

[scotttrinh]

Sorry to ask it here, but is there an industry standard way of keeping a link to my forked edgedb-js in my edgedb projects?

You can use yarn link to link a dependency to a local build.