Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order by types to allow enums #883

Merged
merged 2 commits into from Mar 1, 2024

Conversation

CarsonF
Copy link
Contributor

@CarsonF CarsonF commented Mar 1, 2024

No description provided.

Copy link
Collaborator

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a simple test for this? I think you can add an order_by: movie.genre to

const query = e.select(e.Movie, (movie) => ({
title: true,
characters: (char) => ({
name: true,
order_by: char.name,
...e.is(e.Hero, { secret_identity: true }),
}),
filter_single: e.op(movie.title, "=", "The Avengers"),
}));

@CarsonF
Copy link
Contributor Author

CarsonF commented Mar 1, 2024

That ok?

@CarsonF CarsonF requested a review from scotttrinh March 1, 2024 18:37
@scotttrinh scotttrinh merged commit 18536d1 into edgedb:master Mar 1, 2024
7 of 8 checks passed
@CarsonF CarsonF deleted the bugfix/enum-ordering branch March 1, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants